Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added MinGW threading Capability #608

Merged
merged 2 commits into from Sep 24, 2017
Merged

Added MinGW threading Capability #608

merged 2 commits into from Sep 24, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 8, 2016

I added this for the users who want to use MinGW without boost, i added meganz/mingw-std-threads as a submodule, and updated thread.hpp to include the mingw headers, if required

@zaphoyd zaphoyd merged commit c7bef86 into zaphoyd:develop Sep 24, 2017
@zaphoyd
Copy link
Owner

zaphoyd commented Sep 24, 2017

I've merged this patch with a few changes:

  • I don't want to bring in new hard dependencies so I've removed the submodule to mingw-std-threads. Whether to include this code is something the library user should decide.
  • Since the referenced git repo is one of multiple solutions to threading on MinGW I don't want to hard code the decision to always use it for all library users. A MinGW user could want to use Boost Thread for example instead. As such I've removed the automatic inclusion of these headers if MinGW is detected.
  • Rearranged the checks for mingw-threads to be first/highest priority in the list so that if the user defines _WEBSOCKETPP_MINGW_THREAD_ then WebSocket++ will definitely use that library instead of the STL or Boost.
  • Updated the documentation & FAQ to point MinGW users towards this library as an alternative to Boost threads.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants