Preserve ASIO errors if possible #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods don't need any object to operate on, so make them static to allow calling them without an actual connection object at hand.
vadz
force-pushed
the
preserve-asio-errors
branch
from
d704409 to
94afce9
Compare
This was already done in asio::xxx_socket::connection methods by using translate_ec() which allowed to preserve the error code when possible (i.e. when using Boost.ASIO with Boost.System or standalone ASIO with C++11 std::error_code), but errors also can happen in endpoint methods such as handle_connect(), where they were totally lost and replaced with a rather useless error::pass_through. With these changes, the real error codes are preserved and applications using the library can give more useful error messages if connection fails.
vadz
force-pushed
the
preserve-asio-errors
branch
from
94afce9 to
81ef065
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to give meaningful error messages when connection fails (at least when using compatible ASIO and
system::error_code, see also #651).