Make HTTP Connection header capitalized #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what other implementations do and what the example in RFC 6455 uses.
tommy87
approved these changes
Jul 5, 2018
|
How annoying, but fair enough. If you resubmit this patch to the |
|
@zaphoyd Thanks, I rebased to develop. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what other implementations do and what the example in RFC 6455 uses.
Apparently, no decent browser cares if this is uppercase or lowercase or whatever but apparently Edge (at least the version I have here) does and refuses to open a WebSocket connection otherwise.