-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement getMetadata
for active JS scripts
#442
Conversation
FYI I haven't forgotten this. I did go through a number and they seemed fine. I'll try to finish a review in the next few days. |
Can't we use getHelpLink like the other ascan rules? (I mean it'd have to be implemented but I don't see why it can't be similar) Also should we have write-ups of these in the add-on help like we do for ascan/pascan java rules? (I have mixed feelings: Part of me says yes for consistency, part of me says no because that's just one more thing to maintain.) |
I finally got to read through all of them, seems fine to me. Are there further changes/tweaks coming or shall I go ahead and approve? |
7c2632c
to
ca7ac93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: ricekot <github@ricekot.com>
ca7ac93
to
0b19eaa
Compare
Thank you! |
@psiinon do you want to check this again? |
Part of #440.
Also add relevant alert tags and assign categories. The scan rule IDs for these scripts were taken from the scanners.md file.
The status of these scripts has been set to
alpha
since community-scripts is an alpha add-on.