Implement getMetadata for some more Passive scripts
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricekot
force-pushed
the
passive-scripts-metadata
branch
from
eff0966
to
7a1294c
Compare
|
Added |
kingthorin
reviewed
Jun 5, 2024
passive/Find Credit Cards.js
Outdated
Comment on lines
18
to
19
| // lets make some regular expressions for well known credit cards | ||
| // regex must appear within /( and )/g |
There was a problem hiding this comment.
Should we keep this and just move it down to L27?
ricekot
force-pushed
the
passive-scripts-metadata
branch
from
7a1294c
to
b886b1e
Compare
kingthorin
approved these changes
Jun 7, 2024
thc202
reviewed
Jun 7, 2024
- Update the following scripts to implement the `getMetadata()` function: - passive/find base64 strings.js - passive/Find Credit Cards.js - passive/Find Emails.js - passive/Find Hashes.js - passive/Find HTML Comments.js Also update passive scripts with an existing `getMetadata()` function to also specify a `codeLink` and a `helpLink`. Signed-off-by: ricekot <github@ricekot.com>
ricekot
force-pushed
the
passive-scripts-metadata
branch
from
b886b1e
to
f4ec405
Compare
thc202
approved these changes
Jun 10, 2024
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following scripts to implement the
getMetadata()function:Part of #440.