authhelper: add diag post data + initial auto-detect unit tests #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
authhelper/auto-unittest1
branch
from
978dfe8 to
f6ad249
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
authhelper/auto-unittest1
branch
from
f6ad249 to
c1a1f09
Compare
thc202
approved these changes
Mar 7, 2025
|
Thank you! |
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
kingthorin
reviewed
Mar 7, 2025
| @@ -132,15 +161,15 @@ void shouldAppendCookies() throws Exception { | |||
| void shouldAppendStructuredData() throws Exception { | |||
There was a problem hiding this comment.
shouldAppendPostData
to match the new method name.
There was a problem hiding this comment.
Or "Expected" to not clash with the test below.
kingthorin
approved these changes
Mar 7, 2025
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add sanitized post data to the auth diagnostic data, correctly sanitize set-cookies and added the very start of a framework for testing auto-detection.
Related Issues
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.