Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

automation/pscan: No commas in rule IDs #6257

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Mar 7, 2025

Overview

  • CHANGELOGs > Added change notes.
  • Automation classes > Set message handling to use un-formatted integer strings when including plugin IDs.

Related Issues

N/A

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

Ex:

318837 [ZAP-Automation] INFO  org.parosproxy.paros.CommandLine - Job passiveScan-config started
318837 [ZAP-Automation] INFO  org.parosproxy.paros.CommandLine - Job passiveScan-config set rule 90022 threshold to MEDIUM
318839 [ZAP-Automation] INFO  org.parosproxy.paros.CommandLine - Job passiveScan-config set rule 10202 threshold to OFF
318844 [ZAP-Automation] INFO  org.parosproxy.paros.CommandLine - Job passiveScan-config finished, time taken: 00:00:00

versus

Job passiveScan-config set rule 10,111 threshold to MEDIUM
Job passiveScan-config set rule 10,112 threshold to MEDIUM
Job passiveScan-config set rule 10,113 threshold to MEDIUM
Job passiveScan-config finished, time taken: 00:00:00

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Done and done

@thc202
Copy link
Member

thc202 commented Mar 7, 2025

Thank you!

@kingthorin kingthorin merged commit f40709e into zaproxy:main Mar 7, 2025
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@psiinon
Copy link
Member

psiinon commented Mar 7, 2025

Logo
Checkmarx One – Scan Summary & Details04caf023-6b2c-49f8-84f1-1547205e360b

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Heap_Inspection /addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/AuthTestDialog.java: 260
LOW Use_Of_Hardcoded_Password /addOns/authhelper/src/test/java/org/zaproxy/addon/authhelper/AuthDiagnosticCollectorUnitTest.java: 205

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants