Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add page for Zarr datasets #86

Merged
merged 13 commits into from
Jul 11, 2023
Merged

Conversation

sanketverma1704
Copy link
Member

Linking this from #80.

Added a new page for the public Zarr datasets, rename sub-directory pages to index.md, and remove permalink as discussed in #84. After merging this PR, it can be accessed at https://zarr.dev/datasets.

Let me know what you all think; suggestions are welcome. Thanks!

Screenshot 2023-05-18 at 19 14 15

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few quick thoughts but otherwise 👍

datasets/index.md Outdated Show resolved Hide resolved
datasets/index.md Outdated Show resolved Hide resolved
datasets/index.md Outdated Show resolved Hide resolved
datasets/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make it more clear that we are not trying to make a catalog of all the public Zarr data in the world but rather just providing a few examples.

We also need some kind of filter on what sort of datasets we will accept into this list.

datasets/index.md Outdated Show resolved Hide resolved
datasets/index.md Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member

We also need some kind of filter on what sort of datasets we will accept into this list.

What type of filter are you thinking beyond say a license requirement, @rabernat?

@rabernat
Copy link
Contributor

What type of filter are you thinking beyond say a license requirement, @rabernat?

Just some sort of criteria about what qualifies a dataset to be added to this list. For example:

  • Public, openly licensed
  • Representative of the use case of Zarr in a specific domain
  • Well documented
  • Stable / persistent over time

@sanketverma1704
Copy link
Member Author

sanketverma1704 commented May 21, 2023

Thanks for the comments, @joshmoore and @rabernat.

I've added the changes. Please let me know what you think. Thanks!

Screenshot 2023-05-21 at 13 46 46

datasets/index.md Outdated Show resolved Hide resolved
datasets/index.md Outdated Show resolved Hide resolved
feel free to send a PR to the website <a href="https://github.com/zarr-developers/zarr-developers.github.io/">repository</a>.<br><br>

Please ensure the dataset you're adding to the list is public, free to use,
documented, represents Zarr's use case in a specific domain, and is stable/maintained.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I would understand "represents Zarr's use case in a specific domain. I would also expand on "is stable/maintained", e.g. "Please only include URLs that you expect to be stable and maintained for ..." (the next several years?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!
Made some changes. Check here: https://zarr-developersgithubio--86.org.readthedocs.build/en/86/datasets/

datasets/index.md Outdated Show resolved Hide resolved
sanketverma1704 and others added 6 commits May 26, 2023 16:23
Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
sanketverma1704 and others added 6 commits May 26, 2023 16:43
Co-authored-by: Josh Moore <josh@openmicroscopy.org>
Co-authored-by: Josh Moore <josh@openmicroscopy.org>
Co-authored-by: Josh Moore <josh@openmicroscopy.org>
@sanketverma1704
Copy link
Member Author

If there is no additional feedback, I'd like to proceed with this PR.

The current version can be seen here: https://zarr-developersgithubio--86.org.readthedocs.build/en/86/datasets/

Thanks!

@joshmoore
Copy link
Member

Merging, @rabernat. If you have any follow-ups, let us know.

@joshmoore joshmoore merged commit b328a65 into zarr-developers:main Jul 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants