WIP: Use NumPy's fromfile and tofile
#494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reading and writing data on disk, start using NumPy's `fromfile` and `tofile`.
Instead of opening and closing files ourselves, go ahead and let NumPy handle this when reading from and writing to disk.
|
Hi John, out of curiosity, what's the benefit here of using NumPy versus
plain open()?
…On Mon, 28 Oct 2019, 16:08 jakirkham, ***@***.***> wrote:
For reading and writing data on disk, start using NumPy's fromfile and
tofile.
TODO:
- Add unit tests and/or doctests in docstrings
- Add docstrings and API docs for any new/modified user-facing classes
and functions
- New/modified features documented in docs/tutorial.rst
- Changes documented in docs/release.rst
- Docs build locally (e.g., run tox -e docs)
- AppVeyor and Travis CI passes
- Test coverage is 100% (Coveralls passes)
------------------------------
You can view, comment on, or merge this pull request online at:
#494
Commit Summary
- Use NumPy's `fromfile` and `tofile`
File Changes
- *M* zarr/storage.py
<https://github.com/zarr-developers/zarr-python/pull/494/files#diff-0>
(6)
Patch Links:
- https://github.com/zarr-developers/zarr-python/pull/494.patch
- https://github.com/zarr-developers/zarr-python/pull/494.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#494?email_source=notifications&email_token=AAFLYQVNHRN2RV6BGCOFFCDQQ4E7FA5CNFSM4JF4QGCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUZ5J3Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFLYQQNKMAR6YX2YTXNE7TQQ4E7FANCNFSM4JF4QGCA>
.
|
|
This probably doesn't merit review ATM. It's part of some exploratory work I'm doing. |
|
Cool, no problem.
…On Tue, 29 Oct 2019, 17:55 jakirkham, ***@***.***> wrote:
This probably doesn't merit review ATM. It's part of some exploratory work
I'm doing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#494?email_source=notifications&email_token=AAFLYQR3D3MR5QF3D2FEIBLQRB2KZA5CNFSM4JF4QGCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRPVPY#issuecomment-547551935>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFLYQV34ZQQ46ZHSAVAYVLQRB2KZANCNFSM4JF4QGCA>
.
|
|
I think PR ( #503 ) gets at the actual need a bit cleaner. So will close this out. Thanks for humoring me 🙂 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reading and writing data on disk, start using NumPy's
fromfileandtofile.TODO:
tox -e docs)