PHP CS Fixer

[phpfui]

Added files to run PHPCSFixer and run it.

Due to very old versions of PHP being used in this project, the modern version of PHP CS Fixer can not be included in composer.json. But since this is just a dev tool, it does not matter, as it is just run on a local machine and changes are checked in.

To run, you must install PHPCSFixer globally (or in another project, or temporarily) then run phpcsfixer fix from the project root directory. Check in any changes.

To change the rules, edit the file PhpCsFixer.php in the project root.

Get this merged and I can add PHPStan next.

[zbateson]

Hi @phpfui --

This is great, thanks again! Some of the rules I'd rather keep off -- if I change them tho I assume my code won't be reverted back tho. Could we instead have a pull request just configuring PHPCSFixer? As you have it is fine, and I'll play with it and adjust the rules I don't want, run it and commit it fixed?

[phpfui]

So basically here is how PHP-CD-Fixer works: You specify rules, then run the fixer. It modifies the code to the rules you specify. Then you check in the modified code. This is what I did. I did not do any hand modification. I have also set up git hooks to do this automatically and update the current commit when checking in code. Works well. I can add that as well if you would like, but people would have to configure git locally to do that. There may be a package that might automate that, but have not investigated. Also Linux vs Windows dev envs can get a bit tricky.

What you want to do is modify the rules, the rerun the fixer, then check in the new code. You may want to revert the run I did, just to be 100% sure nothing was lost, but I don't remember doing any hand mods.

There is also a great tool here You should be able to import and export the PhpCsFixer.php file in the project root.

So merge this, change the rules to your specifications, run the fixer, check in the code.

The only other thing we should probably do is to just use one master copy of PhpCcFixer.php in the mb-wrapper package. Since this package is required by the other two, it will always be present and in a known location relative to the current project (vendor/zbateson/mb-wrapper/PhpCsFixer.php). Then we don't have to maintain a version in each package.

Hope this helps clear things up.

[phpfui]

Easy to revert the last commit. So merge and then fix up PhpCsFixer.php to your liking. Easy to revert things, change the config and redo. Once you settle on the right format, I can then put in a PR to use the mb-stream version, then we don't have to maintain separate files. Use this for all my projects and it works great.

[zbateson]

Aah, right -- revert makes sense. Keeping it in mb-wrapper also sounds good, I'll look into that.

For running it, I might configure it to run with 'phing' on mail-mime-parser (I use it to release docs for new versions) and keep it manual on here and mb-wrapper. They see much fewer releases/commits, so can worry about it if that changes. I'll give it some thought.

Thanks again