Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modernize to PHP 7.1 #12

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Modernize to PHP 7.1 #12

merged 3 commits into from
Jan 11, 2023

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Jan 11, 2023

Changes include:

  • Add scalars to method parameters where ever possible.
  • Add return types where ever possible.
  • Upgrade to PHPUnit 7 or higher and remove LegacyPHPUnit package
  • Update readme.md to reflect PHP version support
  • Update github actions to support only PHP 7.1 and higher.
  • Added PHPStan to level 6 for src and tests directories.
  • Ran PHP-CS-Fixer on src and tests directories.
  • Fixed code for testing read method to test against bool, since read always returns string.
  • Removed useless comments @param int $length, but kept @param int $length number of bytes to read.
  • Used @inheritdoc where is made sense.

Run PHPStan and PHPCSFixer on tests
Run PHPStan and PHPCSFixer on src
@zbateson zbateson merged commit 7466ff4 into zbateson:master Jan 11, 2023
@zbateson
Copy link
Owner

Thanks again :)

@phpfui phpfui deleted the PHP71 branch January 13, 2023 23:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants