Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix filters consuming too much data. #1670

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

bbannier
Copy link
Member

@bbannier bbannier commented Feb 7, 2024

We would previously assume that a filter would consume all available data. This only holds if the filter is attached to a top-level unit, but in general not if some sub-unit uses a filter. With this patch we explicitly compute how much data is consumed.

Closes #1652.

@bbannier bbannier self-assigned this Feb 7, 2024
@bbannier bbannier marked this pull request as ready for review February 7, 2024 14:53
@bbannier bbannier requested a review from rsmmr February 7, 2024 14:53
We would previously assume that a filter would consume all available
data. This only holds if the filter is attached to a top-level unit, but
in general not if some sub-unit uses a filter. With this patch we
explicitly compute how much data is consumed.

Closes #1652.
@bbannier bbannier force-pushed the topic/bbannier/issue-1652 branch from e4704de to 1b84d98 Compare February 8, 2024 16:18
@bbannier bbannier requested a review from rsmmr February 9, 2024 11:39
@bbannier bbannier merged commit c39bdb5 into main Feb 14, 2024
19 checks passed
@bbannier bbannier deleted the topic/bbannier/issue-1652 branch February 14, 2024 15:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field of type with filter consumes more data than expected
2 participants