Support/fix public type aliases to units. #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
previously approved these changes
Apr 2, 2024
An alias like `public type Unit1 = Unit2` used to lead to C++-side compiler errors, which this fixes. We also fully support this now by making both `Unit1` and `Unit2` available for parsing to host applications. Internally, the `Unit1` parser is just a small facade pointing to the parsing functions for `Unit2`. Closes #1493.
rsmmr
force-pushed
the
topic/robin/gh-1493-type-alias
branch
from
6bd760c to
6cb6ae8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alias like
public type Unit1 = Unit2used to lead to C++-sidecompiler errors, which this fixes. We also fully support this now by
making both
Unit1andUnit2available for parsing to hostapplications. Internally, the
Unit1parser is just a small facadepointing to the parsing functions for
Unit2.Closes #1493.