Fix if-condition with switch parsing.
#1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser generator was ignoring `if` conditions attached to `switch` constructs. While we actually had a test for this already, turns out we had recorded a broken baseline. Plus, we were testing only one variant of `switch` (expression-based, not look-ahead-based). This implements and tests both variants now. Closes #1759.
bbannier
approved these changes
Jun 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser generator was ignoring
ifconditions attached toswitchconstructs. While we actually had a test for this already, turns out
we had recorded a broken baseline. Plus, we were testing only one
variant of
switch(expression-based, not look-ahead-based). Thisimplements and tests both variants now.
Closes #1759.