Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Feature: Ability to provide barcode with checksum #48

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Feature: Ability to provide barcode with checksum #48

merged 1 commit into from
Dec 26, 2019

Conversation

michalbundyra
Copy link
Member

Added new option "providedChecksum" to indicate if the checksum has been
provided with the barcode text.

Resolves #13

We have now three "similar" options:

  • withChecksum - whether or not the checksum is automatically added to the barcode
  • withChecksumInText - whether or not the checksum is displayed in the textual representation
  • providedChecksum - whether or not the checksum is provided with the barcode text

so the new option is about the input barcode text.
If it's provided validator checks if the provided checksum is valid.

  • Are you creating a new feature?
    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.

Added new option "providedChecksum" to indicate if the checksum has been
provided with the barcode text.

Resolves #13
@michalbundyra
Copy link
Member Author

@christeredvartsen @Gemorroj @povils @silverslice would you be able to have a look on this PR and let me know if you are happy with that feature? I am pinging you, as you where interested in #13. Thanks a lot!

weierophinney added a commit that referenced this pull request Dec 26, 2019
Feature: Ability to provide barcode with checksum
weierophinney added a commit that referenced this pull request Dec 26, 2019
@weierophinney weierophinney merged commit fa43205 into zendframework:develop Dec 26, 2019
@michalbundyra michalbundyra deleted the feature/provided-checksum branch December 27, 2019 05:45
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants