This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Use the console adapter to write instead of echo. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Char prompt was just echoing directly rather than using the writeLine() method from the Console adapter. This was done correctly in the Select prompt already. Using echo can make testing more difficult because you can't mock the write away and instead of to do hacky things like using output buffering.
weierophinney
added a commit
that referenced
this pull request
Feb 8, 2016
Use the console adapter to write instead of echo.
weierophinney
added a commit
that referenced
this pull request
Feb 8, 2016
Also fixed some CS issues in the Char classfile
weierophinney
added a commit
that referenced
this pull request
Feb 8, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 8, 2016
|
Merged to develop for release with 2.6.0 (later today). |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Char prompt was just echoing directly rather than using the writeLine() method from the Console adapter. This was done correctly in the Select prompt already. Using echo can make testing more difficult because you can't mock the write away and instead of to do hacky things like using output buffering.