Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix null value throwing error #41

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Fix null value throwing error #41

merged 4 commits into from
Dec 11, 2018

Conversation

internalsystemerror
Copy link
Contributor

This fixes: #40

See issue for further information.

@weierophinney
Copy link
Member

Please add a test for this new behavior; thanks!

internalsystemerror and others added 4 commits December 11, 2018 10:42
Test for #41

Also modifies the docblock of normalizeConstantValue to no longer
reference `null` values.
@weierophinney
Copy link
Member

I have added tests and a changelog entry, and pushed them to your branch.

@weierophinney weierophinney merged commit e29eacd into zendframework:master Dec 11, 2018
weierophinney added a commit that referenced this pull request Dec 11, 2018
weierophinney added a commit that referenced this pull request Dec 11, 2018
@internalsystemerror
Copy link
Contributor Author

@weierophinney thanks, been extremely busy so I doubt I'll get much time to get back to any of my PRs for a few months still

@internalsystemerror internalsystemerror deleted the patch-1 branch December 12, 2018 10:44
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracting a collection of objects where one contains a NULL value causes XML renderer to error
2 participants