This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fixes offset calculation for paginated Doctrine collections #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was erroneously using the calculated `$pageCount`, which represented the total number of pages in the collection, instead of the `$perPage` value when calculating the result offset. This was due to missing assertions in the unit tests. The assertions have been added, and the code corrected accordingly.
It is called by the ExtractCollection trait, using the discovered page number and number of results to retrieve.
weierophinney
added a commit
that referenced
this pull request
Feb 11, 2019
weierophinney
added a commit
that referenced
this pull request
Feb 11, 2019
Forward port #56 Conflicts: CHANGELOG.md
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was erroneously using the calculated
$pageCount, which represented the total number of pages in the collection, instead of the$perPagevalue when calculating the result offset. This was due to missing assertions in the unit tests. The assertions have been added, and the code corrected accordingly.