-
Notifications
You must be signed in to change notification settings - Fork 136
Fixes $options = null check when use Zend\Valdator\Barcode #52
Fixes $options = null check when use Zend\Valdator\Barcode #52
Conversation
Next Can you paste the results of the added test without "the fix"? |
/** | ||
* @dataProvider provideBarcodeConstructor | ||
*/ | ||
public function testBarcodeConstructorIsNullOrArrayButNoOptionsKey($options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't detail constructor types in the function name, this is already provided by the provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
without the fix, it will got error:
|
Then the source of the issue is:
For me the easiest solution is allow |
@Maks3w I've updated |
Your choice of set an empty array is better |
if use set empty array, it will got:
|
With this? #52 (comment) |
5008575
to
2fd04e5
Compare
@Maks3w should be ok now 👍 |
Rebase and go |
*squash |
2fd04e5
to
137564c
Compare
@Maks3w squashed. |
@Maks3w merge-able ? |
Fixes $options = null check when use Zend\Valdator\Barcode
the constructor has optional
$options = null
but no check for it, this PR fixes it.