This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Fix the module initializer #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializers actually receive the module manager itself, not the module event. As such, we have to pull the event from the module manager instance.
| * @return void | ||
| */ | ||
| public function init($event) | ||
| public function init($moduleManager) |
There was a problem hiding this comment.
Is it possible to typehint the parameter?
There was a problem hiding this comment.
Potentially. We've typically not done it, in order to prevent the inevitable "zend-modulemanager should be listed as a package requirement" issues. For some reason, not using a typehint doesn't trigger those remarks, even though the code ends up working exactly the same.
weierophinney
added a commit
that referenced
this pull request
Apr 18, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 18, 2016
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializers actually receive the module manager itself, not the module event. As such, we have to pull the event from the module manager instance.