Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Stdlib - PriorityList move from Zend\Mvc\Router to Stdlib #5702

Merged
merged 1 commit into from
Mar 4, 2014
Merged

Stdlib - PriorityList move from Zend\Mvc\Router to Stdlib #5702

merged 1 commit into from
Mar 4, 2014

Conversation

turrsis
Copy link
Contributor

@turrsis turrsis commented Jan 10, 2014

Zend\Mvc\Router\PriorityList exist in Zend\Mvc\Router namespace.
But it also required for :

  • Zend\Form\Fieldset : it can be used for $iterator property, and $byName can be deleted (now used both variables).
  • Also if using foreach(Form\Fieldset::getIterator() as $name=> $element) the $name should be element name instead of index (as the Form\Fieldset::getElements())
  • Db\Sql\Update : Because sometime the values set should be reordable (http://dev.mysql.com/doc/refman/5.0/en/ansi-diff-update.html)
  • perhaps somewhere else can be used

@prolic
Copy link
Contributor

prolic commented Jan 25, 2014

Can you please make Zend\Mvc\Router\PriorityList extends the Zend\Stdlib\PriorityList class? This way we can remove code duplication. Thanks.

@Maks3w
Copy link
Member

Maks3w commented Feb 23, 2014

@turrsis I don't see the "move" you're just copying the file without to remove or adapt the old file.

@weierophinney
Copy link
Member

@turrsis Agreed with @prolic -- for BC purposes, the original needs to exist. It can extend the Stdlib variant, but it does need to be present.

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014
@weierophinney weierophinney self-assigned this Mar 4, 2014
weierophinney added a commit that referenced this pull request Mar 4, 2014
Stdlib - PriorityList move from Zend\Mvc\Router to Stdlib
weierophinney added a commit that referenced this pull request Mar 4, 2014
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney weierophinney merged commit 725a9f0 into zendframework:develop Mar 4, 2014
@turrsis turrsis deleted the feature/stdLib-PriorityList branch March 12, 2014 17:33
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
…ure/stdLib-PriorityList

Stdlib - PriorityList move from Zend\Mvc\Router to Stdlib
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants