ドクセル埋め込み対応 #509
Merged
ドクセル埋め込み対応 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-dyoshikawa
commented
Sep 12, 2024
| @@ -8,6 +8,7 @@ span.embed-block { | |||
| } | |||
| .embed-slideshare, | |||
| .embed-speakerdeck, | |||
| .embed-docswell, | |||
There was a problem hiding this comment.
padding-bottomハックで対応する（やや縦が長いスライドの吸収対応になる）
参考: #321 (comment)
| describe('DocswellのスライドURLの場合', () => { | ||
| test('Docswellのiframeを返すこと', () => { | ||
| const html = markdownToHtml( | ||
| '@[docswell](https://www.docswell.com/slide/LK7J5V/embed)' |
There was a problem hiding this comment.
ここがスライドのURLになっていないです。
There was a problem hiding this comment.
ありがとうございます！直しました！ 🙏
cm-igarashi-ryosuke
approved these changes
Sep 18, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
参考: #322
Resolves #321
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストであるより詳しい内容は Pull Request Policy を参照してください。