Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PHP 8.4] Change PHP_DEBUG constant usage to ZEND_DEBUG_BUILD #2422

Merged
merged 1 commit into from
May 11, 2024
Merged

[PHP 8.4] Change PHP_DEBUG constant usage to ZEND_DEBUG_BUILD #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
### Added
- Added support of PHP `8.3` [#2407](https://github.com/zephir-lang/zephir/issues/2407)
- Added support of multiple return types in stubs
- Changed `PHP_DEBUG` const usage to `ZEND_DEBUG_BUILD`

### Changed
- Changed minimal PHP version to `8.0` [#2407](https://github.com/zephir-lang/zephir/issues/2407)
Expand Down
4 changes: 2 additions & 2 deletions src/Compiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
use const INFO_GENERAL;
use const PHP_EOL;
use const PHP_INT_SIZE;
use const PHP_ZTS;
use const ZEND_THREAD_SAFE;
use const SORT_STRING;
use const STDERR;

Expand Down Expand Up @@ -2043,7 +2043,7 @@ private function getWindowsReleaseDir(): string

private function isZts(): bool
{
if (defined('PHP_ZTS') && PHP_ZTS === 1) {
if (defined('ZEND_THREAD_SAFE') && ZEND_THREAD_SAFE === true) {
return true;
}

Expand Down