boards:khadas: adding support for the edge2 #79559
Conversation
|
@nordicjm hey I did the the changes is it fine now ? |
EstAK
force-pushed
the
edge2
branch
2 times, most recently
from
03f76e1 to
008ba4c
Compare
|
@nordicjm hey I have reordered the commits (sorry for making a mess with the git) |
EstAK
force-pushed
the
edge2
branch
3 times, most recently
from
172942c to
b7cf5ef
Compare
|
@nordicjm hello, I have re-ordered the commits and fixed the issues following your inputs,
|
|
hey @carlocaione @npitre @povergoing @SgrrZhf can you take a look at this PR ? thank you in advance :) |
|
@EstAK unfortunately this needs a rebase due to merge conflict. Thanks! |
| @@ -0,0 +1,5 @@ | |||
| board: | |||
| name: khadas_edge2 | |||
There was a problem hiding this comment.
I think we typically wouldn't want the vendor name to prefix the board name, as it's redundant, is it not @nordicjm?
There are some boards that do it, but it's a minority AFAICS. That being said, "edge2" definitely is a very generic name so it doesn't sound like a bad idea to anticipate and namespace it, it's just that I am not sure what the rule/guideline is here.
| @@ -0,0 +1,5 @@ | |||
| board: | |||
| name: khadas_edge2 | |||
There was a problem hiding this comment.
| name: khadas_edge2 | |
| name: khadas_edge2 | |
| full_name: Edge2 |
boards/khadas/edge2/doc/index.rst
Outdated
| .. _khadas_edge2: | ||
|
|
||
| Khadas Edge2 | ||
| ################################# |
There was a problem hiding this comment.
| .. _khadas_edge2: | |
| Khadas Edge2 | |
| ################################# | |
| .. zephyr:board:: khadas_edge2 |
boards/khadas/edge2/doc/index.rst
Outdated
|
|
||
| .. code-block:: console | ||
|
|
||
| mkimage -C none -A arm64 -O linux -a 0x10000000 -e 0x10000000 -d build/zephyr/zephyr.bin build/zephyr/zephyr.img |
There was a problem hiding this comment.
nit
| mkimage -C none -A arm64 -O linux -a 0x10000000 -e 0x10000000 -d build/zephyr/zephyr.bin build/zephyr/zephyr.img | |
| mkimage -C none -A arm64 -O linux -a 0x10000000 -e 0x10000000 -d build/zephyr/zephyr.bin build/zephyr/zephyr.img |
boards/khadas/edge2/doc/index.rst
Outdated
|
|
||
| .. code-block:: console | ||
|
|
||
| mmc read ${pxefile_addr_r} 0x100000 0x1000; bootm start ${pxefile_addr_r}; bootm loados; bootm go |
There was a problem hiding this comment.
| mmc read ${pxefile_addr_r} 0x100000 0x1000; bootm start ${pxefile_addr_r}; bootm loados; bootm go | |
| mmc read ${pxefile_addr_r} 0x100000 0x1000; bootm start ${pxefile_addr_r}; bootm loados; bootm go |
boards/khadas/edge2/doc/index.rst
Outdated
| *** Booting Zephyr OS build XXXXXXXXXXXX *** | ||
| Hello World! khadas_edge2 |
There was a problem hiding this comment.
| *** Booting Zephyr OS build XXXXXXXXXXXX *** | |
| Hello World! khadas_edge2 | |
| *** Booting Zephyr OS build XXXXXXXXXXXX *** | |
| Hello World! khadas_edge2 |
boards/khadas/edge2/doc/index.rst
Outdated
| Overview | ||
| ******** | ||
|
|
||
| See <https://www.khadas.com/edge2> | ||
|
|
||
| Hardware | ||
| ******** | ||
|
|
||
| See <https://docs.khadas.com/products/sbc/edge2/hardware/start> |
There was a problem hiding this comment.
please check rendered output https://builds.zephyrproject.io/zephyr/pr/79559/docs/boards/khadas/edge2/doc/index.html and use the correct ReStructuredText way of adding links
|
@kartben thank you for your feedback I will try to make the changes as soon as possible :) |
added the rk35 series and moved the rk3568 under it Signed-off-by: Esteban Aguililla Klein <esteban.aguililla.klein.pro@outlook.com>
it looks like you might have addressed the feedback -- can you please re-request a review when you feel this is ready (and it might already be the case), otherwise it's hard for reviewers to know (and be notified!) when it's time to have another look :) Thanks! |
|
Also, a reminder to check the rendered output for your docs as there might still be some issues, it would seem |
EstAK
force-pushed
the
edge2
branch
2 times, most recently
from
a436716 to
2bd4655
Compare
added the rk35 series and moved the rk3568 under it Signed-off-by: Esteban Aguililla Klein <esteban.aguililla.klein.pro@outlook.com>
Hello, this PR adds support for the rk3588s soc and khadas edge2 board
The board requires to download a tool and a SPL should I add them directly or it is fine as is with links to them ?