DMA xmc4xxx fixes: Inlcude ongoing transfer in the pending_length field of dma_status() #83870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: DMA
talih0
force-pushed
the
dma_xmc4xxx_fixes
branch
from
7a0f694 to
84944c3
Compare
…length When quering the DMA status we need to return the number of pending bytes left in the transfer. Currently this is inferred by calling XMC_DMA_CH_GetTransferredData(). However, this function actually returns the number of items read from the source peripheral (via CTL.BLOCK_TS). It doesn't guarantee that the last item was fully transferred to the destination. When using the ADDR_ADJ_INCREMENT/DECREMENT options it is better to use DAR register to infer the number of transferred bytes. This points to the memory address where the next data will be written. It only increments after the ongoing transfer from source to destination is completed. Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
In the dma loop_transfer test (test_loop_repeated_start_stop()), the order of calls is dma_config() -> dma_stop() -> dma_start(). This currently does not work on xmc4xxx because after calling dma_stop(), the dma would be in a suspended state. Fix this by leaving the suspended state before exiting dma_stop(). Also don't clear the context (dma_channel->dlr_line and dma_channel->cb) that was setup by dma_config(). Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
Adds overlays for xmc45_relax_kit and xmc47_relax_kit boards. Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
talih0
force-pushed
the
dma_xmc4xxx_fixes
branch
from
84944c3 to
979b464
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses two problems in XMC4xxx DMA driver:
I received feedback from Infineon support in this thread:
https://community.infineon.com/t5/XMC/GPDMA-Unreliable-CTL-BLOCK-TS-for-checking-transferred-items-to-MCU/td-p/763264