driver: video: remove endpoint id in esp32 driver #90090
Conversation
sylvioalves
commented
May 17, 2025
•
sylvioalves
commented
- Remove endpoint ID entry in esp32 video driver needed after API changes.
- Add build_all/video tests for ESP32-S3 video driver.
Remove endpoint ID entry in esp32 video driver needed after API changes. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
github-actions
bot
added
area: Video
github-actions
bot
requested review from
avolmat-st,
josuah,
loicpoulain,
LucasTambor,
marekmatej,
ngphibang,
raffarost,
uLipe and
wmrsouza
Make sure esp32s3 video driver is built during CI tests. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
|
Updated the PR to include esp32s3_eye board video test. |
|
| drivers.video.esp32_dvp.build: | ||
| platform_allow: | ||
| - esp32s3_eye/esp32s3/procpu |
There was a problem hiding this comment.
I am not sure if we need to add the extra_args with an esp32 shield to get this tested in twister (because the device node is usually disabled by default and enabled in a separate shield). If it's the case, you can look at the ST platform example just above:
drivers.video.stm32_dcmi.build:
platform_allow:
- stm32h7b3i_dk/stm32h7b3xx
- arduino_nicla_vision/stm32h747xx/m7
extra_args:
- platform:stm32h7b3i_dk/stm32h7b3xx:SHIELD=st_b_cams_omv_mb1683
We can test this by making some wrong code in the driver and run twister to see if it can detect the error:
west twister -i -T tests/drivers/build_all/video
If it can, so that's fine.
Otherwise, if it takes time to do, we can merge the hot fix first then adding the test later in another PR. What do you think ?
There was a problem hiding this comment.
No need for shield or extra_args as I see. esp32s3_eye/esp32s3/procpu board is stand-alone. For testing porpuses with the device it would need extra .conf file though.
There was a problem hiding this comment.
Now it is building successfully:
INFO - 617/954 esp32s3_eye/esp32s3/procpu drivers.video.esp32_dvp.build
There was a problem hiding this comment.
Ok, tha'ts fine then. Thanks again !
ngphibang
added
the
Hotfix
