Add support for changeset downloads #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress: Made first, minimal, passing test case. Implementation is not full, and there are a bunch of kludges in the code (e.g: selecting a node instead of actually selecting the changeset.)
|
I can't say I've looked at every line in detail, but I don't see any obvious issues. |
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
changeset/#{id}/downloadAPI call.The element sorting is implemented in the same way as openstreetmap-website, which isn't necessarily exactly the same as the order the elements were committed. But it seems to have sufficed up to this point, so perhaps it's okay 😉
A small number of tests have been added, and I'd be really interested to know if you think that there are other important areas or corner-cases which should be tested too.
/cc @tomhughes, @jronak & @pnorman - please let me know if you have any advice on how to improve this code, or if you think something's wrong or needs extra testing. Thanks!