Specify columns explictly when inserting into API tables #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't name the columns explicitly then you are depending on the order of the columns in the database which may vary if the history of the database and how it was updated doesn't match the one you are developing against.
mmd-osm
reviewed
May 25, 2019
| FROM current_relations | ||
| WHERE id = ANY($1)) | ||
| INSERT INTO relations (relation_id, changeset_id, timestamp, version, visible) | ||
| SELECT id AS relation_id, changeset_id, timestamp, version, visible |
There was a problem hiding this comment.
In the current_relations_to_history query below, we use an alias as an SELECT id AS relation_id, whereas current_nodes_to_history and current_ways_to_history don't use an alias SELECT id,.
It doesn't really make a difference here, it's just something I noticed while looking through the changes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't name the columns explicitly then you are depending on the order of the columns in the database which may vary if the history of the database and how it was updated doesn't match the one you are developing against.