Undo "Replace custom array parser by pqxx::array_parser" #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(expected to fail due to an upstream issue in libpqxx)
Fixes zerebubuth#276 Reverts zerebubuth#261 libpqxx seems to treat semicolons as a separator character regardless of the actual field type (Postgresql docs mention that only box type uses semicolon, all other standard types use comma only). As our payload in varchar fields may contain semicolons, the array_agg() result would throw off the libpqxx array parser. So for now we revert to the previous custom parser implementation. Further upstream issue analysis to follow.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
Reverts #261
libpqxx seems to treat semicolons as a separator character regardless of the actual field type (Postgresql docs mention that only box type uses semicolon, all other standard types use comma only).
As our payload in varchar fields may contain semicolons, the array_agg() result would throw off the libpqxx array parser.
So for now we revert to the previous custom parser implementation.
Further upstream issue analysis to follow.