Check user state, only allow db changes for confirmed and active users #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
reviewed
Dec 26, 2022
| // to change the database will be rejected | ||
| if (!selection.is_user_active(*user_id)) | ||
| throw http::forbidden ( | ||
| "You have not permitted the application access to this facility"); |
There was a problem hiding this comment.
That's not really an accurate description is it? This would occur when there was an authorization but the user account had been closed or suspended.
There was a problem hiding this comment.
That’s exactly what Rails returned in that case, I’m only trying to replicate the same response here. I agree, the description isn’t all that helpful.
There was a problem hiding this comment.
api_controller.rb deny_access is where this error message originates from:
def deny_access(_exception)
if doorkeeper_token || current_token
set_locale
report_error t("oauth.permissions.missing"), :forbidden
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283