-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Automatically create github release for tagged versions #332
Conversation
As a heads up: This may probably not work since I’m only collaborator in this repo and cannot create personal access tokens or configure a GITHUB_TOKEN. That’s also the reason why I work mostly with my own fork, and create pull requests from there. As long as I’m working in my own repo, I don’t have that many restrictions. |
I think it should work. Looking at https://github.com/zerebubuth/openstreetmap-cgimap/actions/runs/7079318119/job/19265821617#step:1:24 , the default authentication token does have package and content write permissions that are required for this. |
62a45b1
to
f57e861
Compare
I think we need to double check this with zerebubuth, who owns the repo. While we might be able to publish packages, I have no way to control or manage them afterwards. Also, we should check if publishing packages is really worth the extra effort and does not increase the overall maintenance effort. osm.org uses Ubuntu PPAs at the moment, OpenHistoricalMap is building their own Docker images, so both of our main "customers" would not see an immediate benefit. I introduced Docker images mainly to have a bit more control on package dependencies when running unit tests. They could be also useful for some local testing. However, in general are not meant as is for production usage. Once we start publishing packages, people might have a different expectation, i.e. would expect a more "production like" image. |
Okay, then that's probably not a good idea.
The main benefit of having prebuilt packages available would be for new users who want to quickly try out cgimap. Maybe that's not really worth it since that's a very limited target audience.
We could also simply remove the docker image upload from the workflow and just have the automatic release creation (+ maybe the binary artifact). |
141edd8
to
81e6a3a
Compare
b766d6a
to
3b6c868
Compare
Now with the discussion in #381 we could attach the build artifact to the new release, similar to how https://github.com/trstringer/azblogfilter/releases looks like. In our case this would be single .deb file for amd64 and Debian 12, at least for now. I belive this could avoid some of issues with package registries for now. |
I've included at least the softprops/action-gh-release based release process in #449 now. Thanks a lot for the PR! |
Use github actions to automatically create a release for versions tagged with
v*.*.*
Currently based on Ubuntu 22.04 docker image