Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unit test: user in status pending cannot upload changesets #406

Merged
merged 1 commit into from
May 13, 2024
Merged

Unit test: user in status pending cannot upload changesets #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 2 additions & 54 deletions test/test_apidb_backend_changeset_uploads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2009,61 +2009,11 @@ TEST_CASE_METHOD( DatabaseTestsFixture, "test_osmchange_end_to_end", "[changeset
REQUIRE(req.response_status() == 401);
}

/*
SECTION("User logging on with display name (different case)")
{
// set up request headers from test case
req.set_header("HTTP_AUTHORIZATION", "Basic REVNTzpwYXNzd29yZA==");

req.set_payload(R"(<?xml version="1.0" encoding="UTF-8"?>
<osmChange version="0.6" generator="iD">
<create><node id="-1" lon="11" lat="46" changeset="1"/></create>
</osmChange>)" );

// execute the request
process_request(req, limiter, generator, route, *sel_factory, upd_factory.get());

REQUIRE(req.response_status() == 200);
}

SECTION("User logging on with email address rather than display name")
{
// set up request headers from test case
req.set_header("HTTP_AUTHORIZATION", "Basic ZGVtb0BleGFtcGxlLmNvbTpwYXNzd29yZA==");

req.set_payload(R"(<?xml version="1.0" encoding="UTF-8"?>
<osmChange version="0.6" generator="iD">
<create><node id="-1" lon="11" lat="46" changeset="1"/></create>
</osmChange>)" );

// execute the request
process_request(req, limiter, generator, route, *sel_factory, upd_factory.get());

REQUIRE(req.response_status() == 200);
}

SECTION("User logging on with email address with different case and additional whitespace rather than display name")
{
// set up request headers from test case
req.set_header("HTTP_AUTHORIZATION", "Basic ICAgZGVtb0BleGFtcGxlLkNPTSAgIDpwYXNzd29yZA==");

req.set_payload(R"(<?xml version="1.0" encoding="UTF-8"?>
<osmChange version="0.6" generator="iD">
<create><node id="-1" lon="11" lat="46" changeset="1"/></create>
</osmChange>)" );

// execute the request
process_request(req, limiter, generator, route, *sel_factory, upd_factory.get());

REQUIRE(req.response_status() == 200);
}

SECTION("User is in status pending")
{
tdb.run_sql(R"(UPDATE users SET status = 'pending' where id = 1;)");

// set up request headers from test case

req.set_payload(R"(<?xml version="1.0" encoding="UTF-8"?>
<osmChange version="0.6" generator="iD">
<create><node id="-5" lon="11.625506992810122" lat="46.866699181636555" version="0" changeset="1"/></create>
Expand All @@ -2072,13 +2022,11 @@ TEST_CASE_METHOD( DatabaseTestsFixture, "test_osmchange_end_to_end", "[changeset
// execute the request
process_request(req, limiter, generator, route, *sel_factory, upd_factory.get());

// Basic Auth in status "pending" should return status HTTP 401
REQUIRE(req.response_status() == 401);
REQUIRE_THAT(req.body().str(), Equals("Incorrect user or password"));
// User in status "pending" should return status HTTP 403
REQUIRE(req.response_status() == 403);

tdb.run_sql(R"(UPDATE users SET status = 'confirmed' where id = 1;)");
}
*/

SECTION("User is blocked (needs_view)")
{
Expand Down