Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wheels-building CI Action. #138

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Wheels-building CI Action. #138

merged 5 commits into from
Nov 6, 2023

Conversation

WRansohoff
Copy link
Contributor

@WRansohoff WRansohoff commented Nov 6, 2023

Add an action to build wheels for switchboard.

Tested by pip installing the .whl file on Linux / x86_64 / Python 3.8.

@WRansohoff WRansohoff marked this pull request as ready for review November 6, 2023 18:48
@WRansohoff WRansohoff requested a review from sgherbst November 6, 2023 18:48
Copy link
Contributor

@sgherbst sgherbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested by downloading switchboard-0.0.26-cp311-cp311-macosx_10_13_x86_64.whl from GitHub Actions, then pip-installing on macOS 12.6.6 in a fresh Python 3.11 environment. I verified that the examples run even when the examples folder is moved outside of the switchboard repo (to check for relative path issues).

@sgherbst sgherbst merged commit e873486 into main Nov 6, 2023
5 checks passed
@sgherbst sgherbst deleted the wr/wheels_build branch November 6, 2023 19:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants