Update for NumPy 2.0 #244
Merged
Update for NumPy 2.0 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that came about with the recent release of NumPy 2.0. There were a few places where
np.array()was used withcopy=False, and that started causing exceptions because NumPy could not avoid making a copy.To solve this, I simply removed
copy=False. The performance impact should be low, because thecopy=Falseoption only came into play when writing NumPy integers (not arrays) as a UMI or AXI/AXI-Lite payload. Worst case, a few extra bytes will have to be copied forwrite()andatomic()operations, which should not be a bottleneck. In fact, it's possible that those bytes were already being copied and not throwing an exception under NumPy 1.0 behavior.