Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement Debug for async futures/streams #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jf2048
Copy link

@jf2048 jf2048 commented Oct 19, 2022

Just for completeness, these were the only things I noticed where it was missing.

@zesterer
Copy link
Owner

zesterer commented Oct 21, 2022

Thanks!

Edit: It seems like this PR is failing, perhaps it's better to implement Debug manually? Avoiding revealing internal implementation details would also be good, I think.

@jf2048
Copy link
Author

jf2048 commented Oct 22, 2022

Whoops, I guess my rust-analyzer had a hiccup or something :)

I changed it to have Debug on those private structs, but I also can change it to just be an empty implementation of Debug for those fields/variants, would that work?

@jf2048
Copy link
Author

jf2048 commented Oct 23, 2022

Now changed it to have empty implementation

@zesterer
Copy link
Owner

Thanks, this is ideal. It seems there is a conflict though, but this should be a trivial change.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants