Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add comments to smart contracts #72

Merged
merged 12 commits into from
Mar 21, 2023
Merged

Add comments to smart contracts #72

merged 12 commits into from
Mar 21, 2023

Conversation

andresaiello
Copy link
Collaborator

Summary

  • Add comments on smart contracts

@andresaiello andresaiello marked this pull request as ready for review March 20, 2023 16:59
lucas-janon
lucas-janon previously approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresaiello @lucas-janon
Update packages/zeta-app-contracts/contracts/multi-chain-value/MultiC…
2645ab1 
…hainValue.sol

Co-authored-by: Lucas <ljanon@gmail.com>
lucas-janon
lucas-janon reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also standardize using @dev everywhere instead of @dev:.

andresaiello and others added 2 commits March 20, 2023 16:31
@andresaiello @lucas-janon
Update packages/zeta-app-contracts/contracts/multi-chain-value/MultiC…
807ea0b 
…hainValue.sol

Co-authored-by: Lucas <ljanon@gmail.com>
@andresaiello @lucas-janon
Update packages/zeta-app-contracts/contracts/multi-chain-value/MultiC…
bd3b406 
…hainValue.sol

Co-authored-by: Lucas <ljanon@gmail.com>
lucas-janon
lucas-janon approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresaiello andresaiello merged commit a3f689d into main Mar 21, 2023
@andresaiello andresaiello deleted the andy/pd-2916-add-comments-to-smart-contracts-for-oz branch March 21, 2023 15:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bbbeeeee bbbeeeee bbbeeeee left review comments

@lucas-janon lucas-janon lucas-janon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresaiello @bbbeeeee @lucas-janon