Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(zetaclient): use chain name in metrics (#3484) #3493

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Feb 6, 2025

Backport #3484 and prepare v27.0.2 release

@gartnera gartnera requested a review from a team as a code owner February 6, 2025 16:52
Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera enabled auto-merge (squash) February 6, 2025 16:55
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.42%. Comparing base (3dc1eda) to head (162b3da).
Report is 1 commits behind head on release/v27.

Files with missing lines Patch % Lines
zetaclient/zetacore/client_crosschain.go 0.00% 3 Missing ⚠️
zetaclient/chains/ton/ton.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           release/v27    #3493   +/-   ##
============================================
  Coverage        64.41%   64.42%           
============================================
  Files              436      436           
  Lines            30375    30376    +1     
============================================
+ Hits             19566    19569    +3     
+ Misses            9968     9966    -2     
  Partials           841      841           
Files with missing lines Coverage Δ
pkg/rpc/clients_crosschain.go 48.83% <ø> (ø)
zetaclient/chains/bitcoin/bitcoin.go 51.36% <100.00%> (+0.33%) ⬆️
zetaclient/chains/evm/evm.go 57.29% <100.00%> (+0.22%) ⬆️
zetaclient/chains/solana/solana.go 56.60% <100.00%> (+0.27%) ⬆️
zetaclient/chains/ton/ton.go 0.00% <0.00%> (ø)
zetaclient/zetacore/client_crosschain.go 47.05% <0.00%> (+2.61%) ⬆️

@gartnera gartnera merged commit e33f8ab into release/v27 Feb 6, 2025
42 of 43 checks passed
@gartnera gartnera deleted the v27-use-chain-name-metrics branch February 6, 2025 17:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants