Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add Go code generation for IDL #52

Merged
merged 14 commits into from
Feb 11, 2025
Merged

chore: add Go code generation for IDL #52

merged 14 commits into from
Feb 11, 2025

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Oct 9, 2024

Generate Go code used in node for the programs IDL.

There are limitation right now as for example not all fields of the IDL are generated.

The current idea will first be for node to import the package in this repo so it can be visualized what version is tied to the current code in ZetaClient and prevent interface breaking

@lumtis lumtis linked an issue Oct 9, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.09%. Comparing base (0d24a71) to head (0384ef0).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #52   +/-   ##
=====================================
  Coverage   1.09%   1.09%           
=====================================
  Files          1       1           
  Lines        456     456           
=====================================
  Hits           5       5           
  Misses       451     451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skosito
Copy link
Contributor

skosito commented Oct 24, 2024

@lumtis i renamed a module (it was missing zeta-chain) and generated latest gateway.go, started integrating with this PR (not yet complete): zeta-chain/node#2984

@skosito
Copy link
Contributor

skosito commented Feb 10, 2025

@lumtis i think we can merge this because we use Discriminators generated from here, and now we are adding execute and execute_spl functions, so discriminators should be available for zetaclient

we can find a better way to generate go bindings, but as tmp solution this seems fine

@lumtis lumtis marked this pull request as ready for review February 11, 2025 10:26
@lumtis lumtis requested a review from a team as a code owner February 11, 2025 10:26
@lumtis
Copy link
Member Author

lumtis commented Feb 11, 2025

@lumtis i think we can merge this because we use Discriminators generated from here, and now we are adding execute and execute_spl functions, so discriminators should be available for zetaclient

we can find a better way to generate go bindings, but as tmp solution this seems fine

Sounds good

@lumtis lumtis merged commit ca00896 into main Feb 11, 2025
15 checks passed
@lumtis lumtis deleted the go-generation branch February 11, 2025 10:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate or produce Go binding on this repository
3 participants