This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Suppress only specific database exception #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only suppressed exception is InvalidArgumentException at |
|
Matching exception by message is so fragile, it would be better to introduce a new specific exception in Metadata\Source\Factory. |
Allow all other exceptions to fall throw. Fixes zfcampus#364 Does not conflict with zfcampus#304
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
Suppress only specific database exception
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
|
Thanks, @Naktibalda |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow all other exceptions to fall throw.
Fixes #364
Does not conflict with #304