Make compatible with pytorch 1.11 and newer; bugfix #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Murthy <krrish94@gmail.com>
Signed-off-by: Krishna Murthy <krrish94@gmail.com>
okojoalg
approved these changes
Dec 28, 2022
|
Nudging to see if this can be merged into It is a few-line fix that makes compatible with newer pytorch versions |
|
@krrish94 Thanks for the fix. Sorry for the delay. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version is incompatible with pytorch 1.11 and newer due to breaking changes.
Two commits feature in this PR
The first commit enables compatibility with newer pytorch versions (Issue #411)
45d5f8c
THCudaCheckis deprecated Remove THCGeneral.cpp pytorch/pytorch#66391 in favour ofC10_CUDA_CHECKThe other commit fixed this bug 00167dc
Tested this out, and it compiles and runs on pytorch 1.11 and 1.13