Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tabled_derive/ Fix issue with Cow usage #397

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

zhiburt
Copy link
Owner

@zhiburt zhiburt commented Mar 24, 2024

Seems to work @elenakrittik?

#[test]
fn test_display_with_2() {
#[derive(tabled::Tabled)]
struct Struct<'a> {
#[tabled(display_with("std::path::Path::display"))]
path: &'a std::path::Path,
}
}

close #395

@zhiburt zhiburt force-pushed the patch-fix-cow-issue-with-display-with branch from dabd317 to 3c8ae41 Compare March 24, 2024 23:59
@zhiburt zhiburt force-pushed the patch-fix-cow-issue-with-display-with branch from 3c8ae41 to c0fea92 Compare March 25, 2024 00:02
@elenakrittik
Copy link

Yep, works for me with this patch. Thanks

@zhiburt zhiburt merged commit a5b9027 into master Mar 25, 2024
79 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"the trait From<std::path::Display<'_>> is not implemented for Cow<'_, _>"
2 participants