Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

libunwind: fix unwinding through libunwind stack frames #9662

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

Kha
Copy link
Contributor

@Kha Kha commented Aug 31, 2021

This fixes #9591 on x86_64-linux-gnu, and presumably on ARM. Not sure about other platforms, are there platforms that use libunwind but not unwind tables? And should this change come with a test (in test/standalone/c_compiler?)?

@andrewrk
Copy link
Member

andrewrk commented Sep 1, 2021

Thanks for the patch! I'm happy to accept this as is, and will do so now, but if you felt inspired to follow this up with a test case, I would suggest adding a case here: https://github.com/ziglang/zig/blob/master/test/stack_traces.zig and then adding the necessary test harness improvements needed here:

pub const StackTracesContext = struct {

@andrewrk andrewrk merged commit 9d4a6d6 into ziglang:master Sep 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zig c++ does not support exceptions anymore
2 participants