Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use zigpy types where possible #162

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Use zigpy types where possible #162

merged 2 commits into from
Oct 9, 2023

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Oct 4, 2023

Use zigpy types for Bool and big endian ints instead of own implementation.
Also move ModemStatus and RegistrationStatus to types.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2f2e1ae) 100.00% compared to head (89a343e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          830       777   -53     
=========================================
- Hits           830       777   -53     
Files Coverage Δ
zigpy_xbee/api.py 100.00% <100.00%> (ø)
zigpy_xbee/types.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shulyaka Shulyaka marked this pull request as ready for review October 4, 2023 16:56
@puddly puddly merged commit 66a1f42 into zigpy:dev Oct 9, 2023
@Shulyaka Shulyaka deleted the zigpy_types branch October 10, 2023 18:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants