Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move more sync functions to executor #159

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Oct 17, 2024

It appears is_pizigate and is_zigate_din relied on glob and a few other sync calls.

Fixes the (innocuous) warning seen in home-assistant/core#128615

@puddly puddly force-pushed the puddly/fix-blocking-call-in-event-loop branch from 8915644 to 94ab3b0 Compare October 17, 2024 22:55
@puddly puddly merged commit 93c7358 into zigpy:dev Oct 25, 2024
12 checks passed
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.50%. Comparing base (4587d33) to head (294c1a1).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #159      +/-   ##
==========================================
+ Coverage   46.42%   46.50%   +0.08%     
==========================================
  Files           8        8              
  Lines        1316     1318       +2     
==========================================
+ Hits          611      613       +2     
  Misses        705      705              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant