Add Hamming distance to cuvs CAGRA #1056
Conversation
Signed-off-by: Mickael Ide <mide@nvidia.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lowener The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lowener 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Presburger
requested review from
Presburger and
alexanderguzhva
and removed request for
foxspy and
chasingegg
Signed-off-by: Mickael Ide <mide@nvidia.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
=========================================
+ Coverage 0 72.05% +72.05%
=========================================
Files 0 86 +86
Lines 0 8196 +8196
=========================================
+ Hits 0 5906 +5906
- Misses 0 2290 +2290 |
| @@ -63,6 +63,7 @@ static std::set<std::pair<std::string, VecType>> legal_knowhere_index = { | |||
| {IndexEnum::INDEX_GPU_IVFFLAT, VecType::VECTOR_FLOAT}, | |||
| {IndexEnum::INDEX_GPU_IVFPQ, VecType::VECTOR_FLOAT}, | |||
| {IndexEnum::INDEX_GPU_CAGRA, VecType::VECTOR_FLOAT}, | |||
| {IndexEnum::INDEX_GPU_CAGRA, VecType::VECTOR_INT8}, | |||
There was a problem hiding this comment.
What is the reason for using VECTOR_INT8, not VECTOR_BINARY? This may prevent the further use case when we're using cagra with int8
| @@ -18,5 +18,6 @@ | |||
| #include "common/cuvs/proto/cuvs_index_kind.hpp" | |||
|
|
|||
| namespace cuvs_knowhere { | |||
| template struct cuvs_knowhere_index<cuvs_proto::cuvs_index_kind::cagra>; | |||
| template struct cuvs_knowhere_index<cuvs_proto::cuvs_index_kind::cagra, float>; | |||
| template struct cuvs_knowhere_index<cuvs_proto::cuvs_index_kind::cagra, std::uint8_t>; | |||
No description provided.