explicit installation of bayesian-changepoint-detection no longer needed #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2022
|
@sayanchk - Can you take a quick look at this PR? |
snazzyfox
approved these changes
Oct 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Leveraging https://pypi.org/project/bayescd now since its available via PyPI instead of explicitly installing bayesian-changepoint-detection in our ci/cd pipelines
Why:
We will end up installing the same package twice (via PyPI and explicitly) and will cause issues with test cases when our ci/cd pipelines are triggered.
This will close issue #119