AIP-8434 resilient_flow.py fix #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
talebzeghmi
commented
May 21, 2024
talebzeghmi
commented
- WFSDK resilient_flow.py to handle DEFAULT_REQUEUE_TIME=1m
- The manner in which resilient_flow.py tests resiliency is by a hard kubectl pod delete immediately when the start step begins. This does not allow the argo-wf-controller time (1m) to even know that the pod has started, and hence attempts to start the step again and again.
- WFSDK resilient_flow.py to handle DEFAULT_REQUEUE_TIME=1m - The manner in which resilient_flow.py tests resiliency is by a hard kubectl pod delete immediately when the start step begins. This does not allow the argo-wf-controller time (1m) to even know that the pod has started, and hence attempts to start the step again and again.
cloudw
approved these changes
May 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.