Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AIP-8440 retry opsgenie test intermittent error #299

Merged
merged 3 commits into from
May 23, 2024
Merged

AIP-8440 retry opsgenie test intermittent error #299

merged 3 commits into from
May 23, 2024

Conversation

talebzeghmi
Copy link
Collaborator

@talebzeghmi talebzeghmi commented May 22, 2024 •
edited
Loading

Hardening this test is important to avoid intermittent issues and AIP engineers retrying this test that may mask true failures.

see failure https://gitlab.zgtools.net/analytics/artificial-intelligence/ai-platform/sdks/zillow-metaflow/-/jobs/37777543

FAILED run_integration_tests.py::test_error_and_opsgenie_alert - assert (429 == 200 or 429 == 202)
 +  where 429 = <Response [429]>.status_code
 +  and   429 = <Response [429]>.status_code

429 is this error: 429 Too Many Requests - HTTP | MDN

@talebzeghmi talebzeghmi requested a review from cloudw May 22, 2024 21:00
@talebzeghmi talebzeghmi changed the title AIP-8440 retry opsgenie error AIP-8440 retry opsgenie test intermittent error May 22, 2024
@talebzeghmi talebzeghmi merged commit 8a37942 into feature/aip May 23, 2024
4 checks passed
@talebzeghmi talebzeghmi deleted the tz/AIP-8440-retry-opsgenie-error branch May 23, 2024 02:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cloudw cloudw cloudw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talebzeghmi @cloudw