Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding ability to run latest argo workflow template #303

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Adding ability to run latest argo workflow template #303

merged 12 commits into from
Aug 20, 2024

Conversation

cloudw
Copy link
Collaborator

@cloudw cloudw commented Aug 10, 2024

Allow triggering the latest workflow of a specific project, branch or template_name_prefix.

@cloudw cloudw self-assigned this Aug 10, 2024
talebzeghmi
talebzeghmi requested changes Aug 12, 2024
View reviewed changes
metaflow/plugins/aip/argo_utils.py Outdated Show resolved Hide resolved
metaflow/plugins/aip/argo_utils.py Outdated Show resolved Hide resolved
metaflow/plugins/aip/argo_utils.py Outdated Show resolved Hide resolved
@cloudw
Copy link
Collaborator Author

cloudw commented Aug 14, 2024 •
edited
Loading

TODO: Unit test / integration tests are still missing. I'll make sure they are added prior to merging. Tests added.

Meanwhile, please let me know how you feel about the approach here.

talebzeghmi
talebzeghmi reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@talebzeghmi talebzeghmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turn around! This is much cleaner than before!

metaflow/plugins/aip/aip_cli.py Show resolved Hide resolved
metaflow/plugins/aip/tests/flows/flow_triggering_flow.py Outdated Show resolved Hide resolved
metaflow/plugins/aip/tests/flows/flow_triggering_flow.py Outdated Show resolved Hide resolved
talebzeghmi
talebzeghmi approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@talebzeghmi talebzeghmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@cloudw cloudw force-pushed the yunw/AIP-8187-run-latest-wftemplate branch from a88ce45 to 6c5e60f Compare August 14, 2024 21:56
cloudw
cloudw commented Aug 14, 2024
View reviewed changes
metaflow/plugins/aip/aip.py Outdated Show resolved Hide resolved
metaflow/metaflow_config.py Show resolved Hide resolved
@cloudw
Copy link
Collaborator Author

cloudw commented Aug 14, 2024

Pending merge on integration test results.

talebzeghmi
talebzeghmi requested changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@talebzeghmi talebzeghmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments, thank you!

@cloudw cloudw force-pushed the yunw/AIP-8187-run-latest-wftemplate branch from b3c3766 to 68c4a7d Compare August 19, 2024 20:51
@cloudw cloudw merged commit 97ab1e6 into feature/aip Aug 20, 2024
4 checks passed
@cloudw cloudw deleted the yunw/AIP-8187-run-latest-wftemplate branch August 20, 2024 04:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cavandervoort cavandervoort cavandervoort left review comments

@talebzeghmi talebzeghmi talebzeghmi requested changes

Assignees

@cloudw cloudw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cloudw @talebzeghmi @cavandervoort