refactor: avoid manipulating state directly

zillow · Nov 17, 2022 · 6ca5853 · 6ca5853
1 parent 107e2bb
commit 6ca5853
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/components/ReactSlider/ReactSlider.jsx b/src/components/ReactSlider/ReactSlider.jsx
@@ -836,7 +836,10 @@ class ReactSlider extends React.Component {
     }
 
     move(newValue) {
-        const { index, value } = this.state;
+        // Clone this.state.value since we'll modify it temporarily
+        // eslint-disable-next-line zillow/react/no-access-state-in-setstate
+        const value = this.state.value.slice();
+        const { index } = this.state;
         const { length } = value;
 
         // Short circuit if the value is not changing